launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #11355
Re: [Merge] lp:~wallyworld/launchpad/branch-infotype-portlet-1040999 into lp:launchpad
Thanks!
> 16 + @enabled_with_permission('launchpad.Edit')
> 17 + def visibility(self):
> 18 + """Return the 'Set information type' Link."""
> 19 + text = 'Change information type'
> 20 + return Link('+edit-information-type', text)
>
> Should this be information_type instead of visibility?
>
I considered it but bugs uses 'visibility' for exactly the same thing and I wanted to be consistent.
How strongly do you feel about changing it?
--
https://code.launchpad.net/~wallyworld/launchpad/branch-infotype-portlet-1040999/+merge/121404
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
Follow ups
References