launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Review: Approve code

This looks like excellent work. I have one mis-giving:

373	- BranchCannotChangeInformationType,
374	- branch.setPrivate,
375	- True, branch.owner)
376	+ CannotChangeInformationType,
377	+ branch.setPrivate, True, branch.owner)

395	- BranchCannotChangeInformationType,
396	- branch.setPrivate,
397	- False, branch.owner)
398	+ CannotChangeInformationType,
399	+ branch.setPrivate, False, branch.owner)

Given you've added text to the branch cases that raise CannotChangeInformationType, can you flip these tests to making use of self.assertRaisesWithContent() and make certain the exception text is right.
-- 
https://code.launchpad.net/~wgrant/launchpad/bug-restrict-type/+merge/121989
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.