launchpad-reviewers team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

its curious that you're doing chmod after you've put the files in place, given the big in comments there about a race condition.  (which I honestly do not think that is a large concern as this will be very small window and not a common operation).

But why wouldn't you fix permissions *before* you move it into place?

-- 
https://code.launchpad.net/~allenap/maas/maas-set-correct-file-permissions/+merge/122310
Your team MAAS Maintainers is requested to review the proposed merge of lp:~allenap/maas/maas-set-correct-file-permissions into lp:maas.