launchpad-reviewers team mailing list archive

[Benjamin Kerensa <bkerensa@xxxxxxxxxx>]

Benjamin Kerensa has proposed merging lp:~bkerensa/launchpad/fix-for-1044457 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~bkerensa/launchpad/fix-for-1044457/+merge/122414

Custom Widgets had trivial spacing which I stripped out sicne it was not needed and also one of the custom widgets in question had stopped working maybe as result of the spacing ??
-- 
https://code.launchpad.net/~bkerensa/launchpad/fix-for-1044457/+merge/122414
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bkerensa/launchpad/fix-for-1044457 into lp:launchpad.

=== modified file 'lib/lp/registry/browser/team.py'
--- lib/lp/registry/browser/team.py	2012-08-15 22:01:39 +0000
+++ lib/lp/registry/browser/team.py	2012-09-02 18:16:19 +0000
@@ -1000,11 +1000,10 @@
     label = page_title
 
     custom_widget('teamowner', HiddenUserWidget)
-    custom_widget(
-        'renewal_policy', LaunchpadRadioWidget, orientation='vertical')
-    custom_widget(
-        'membership_policy', LaunchpadRadioWidgetWithDescription,
+    custom_widget('renewal_policy', LaunchpadRadioWidget, orientation='vertical')
+    custom_widget('membership_policy', LaunchpadRadioWidgetWithDescription,
         orientation='vertical')
+            widget_class='field subordinate')
     custom_widget('defaultrenewalperiod', IntWidget,
         widget_class='field subordinate')
 
@@ -1071,8 +1070,7 @@
 
     # Use a dropdown - Javascript will be used to change this to a choice
     # popup widget.
-    custom_widget(
-        'membership_policy', LaunchpadDropdownWidget,
+    custom_widget('membership_policy', LaunchpadDropdownWidget,
         orientation='vertical')