launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Review: Needs Fixing code

Hi Benjamin,

This looks like great work, except that Launchpad has a policy that every code change has test coverage, and it's clear from the previous MP for this branch that it does not. I would suggest making use of the test that Curtis Hovey linked in the previous review.

This branch also introduces an unused import, since lib/lp/registry/browser/team.py no longer makes use of StrippedTextWidget.
-- 
https://code.launchpad.net/~bkerensa/launchpad/fix-for-1044457/+merge/122437
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.