launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

The proposal to merge lp:~sinzui/launchpad/support-apk-types into lp:launchpad has been updated.

Description changed to:

The product release finder does not support android packages. Projects
and organisations like Canonical cannot automatically upload new
releases on remote servers.

--------------------------------------------------------------------

RULES

    Pre-implementation: karni
    * We agreed that the proper file name u1f-google-1.2.4.apk
      should be found by the PRF and the milestone will be names 1.2.4
    * Update flavor_pattern  used by extract_version to support .apk

QA

    * Set the file release pattern for a series to
      http://people.canonical.com/~karni/android/u1f/u1f-google-1.*.apk
    * Run ./cronscripts/product-release-finder.py
    * Verify the series has a milestone for 1.2.4 with an apk release file.

LINT

Linting changed files:
    lib/lp/registry/scripts/productreleasefinder/finder.py
    lib/lp/registry/tests/test_prf_finder.py

TEST

    ./bin/test -vvc -t extract_version lp.registry.tests.test_prf_finder

IMPLEMENTATION

Updated the RE to recognise .apk as a valid release extension.
    lib/lp/registry/scripts/productreleasefinder/finder.py
    lib/lp/registry/tests/test_prf_finder.py

For more details, see:
https://code.launchpad.net/~sinzui/launchpad/support-apk-types/+merge/122757
-- 
https://code.launchpad.net/~sinzui/launchpad/support-apk-types/+merge/122757
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/support-apk-types into lp:launchpad.