launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Approve code

We do not want to write python in TAL. The expression on line 342 could be moved into a property of the view, or you can  test an attribute that is unique to products or distribution. I think the latter might suffice because the paragraphs are about licensing and commercial subscriptions, the object has to have one of those attrs for the text to be applicable. Maybe?
    <tal:what-shared condition="exists:context/licenses">
Or
    <tal:what-shared condition="context/license|nothing">
Which verifies that there are licenses to discuss licensing. 
-- 
https://code.launchpad.net/~wallyworld/launchpad/default-distro-policies-1041002/+merge/122802
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.