launchpad-reviewers team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

This solution will cause automated upgrades to fail if isc-dhcp ever makes a change to /etc/default/isc-dhcp-server .  The likelyhood of that maybe small, but the fallout is large, and this is against debian policy, so accepting this code means knowingly creating a bug.

maintaining our own upstart job for "maas-dhcpd" is not "a lot of extra weight".  Several packages essentially do the same with dnsmasq (libvirt-bin, lxc, network-manager) so there is good prior art for that approach.
The apparmor profile for /usr/sbin/dhcpd is a bigger issue.
-- 
https://code.launchpad.net/~jtv/maas/apply-dhcp_interfaces/+merge/122796
Your team MAAS Maintainers is requested to review the proposed merge of lp:~jtv/maas/apply-dhcp_interfaces into lp:maas.