launchpad-reviewers team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

On Thursday 06 September 2012 13:38:24 you wrote:
> +packaging := lp:~maas-maintainers/maas/packaging.$(DISTRIB_CODENAME)
> +
> +# Special-case Quantal.
> +ifeq ($(DISTRIB_CODENAME),quantal)
> +packaging := lp:~maas-maintainers/maas/packaging
> +endif

The logic is reversed, packaging.precise is the special case.  So I'd write 
this as:

packaging := lp:~maas-maintainers/maas/packaging

# Special-case Precise
ifeq ($(DISTRIB_CODENAME),precise)
packaging := lp:~maas-maintainers/maas/packaging.precise
endif

-- 
https://code.launchpad.net/~allenap/maas/acceptance/+merge/123078
Your team MAAS Maintainers is requested to review the proposed merge of lp:~allenap/maas/acceptance into lp:maas.