launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/request-review-error-1046550 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1046550 in Launchpad itself: "Not possible to request review on merge proposal"
  https://bugs.launchpad.net/launchpad/+bug/1046550

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/request-review-error-1046550/+merge/123493

A simple fix for an issue which was there for a while but only breaks with yui 3.5.1

Y.one("[id=field.review_type]")

was missing quotes around the attr value:

Y.one('[id="field.review_type"]')

-- 
https://code.launchpad.net/~wallyworld/launchpad/request-review-error-1046550/+merge/123493
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/request-review-error-1046550 into lp:launchpad.

=== modified file 'lib/lp/code/javascript/branchmergeproposal.reviewcomment.js'
--- lib/lp/code/javascript/branchmergeproposal.reviewcomment.js	2012-07-07 14:00:30 +0000
+++ lib/lp/code/javascript/branchmergeproposal.reviewcomment.js	2012-09-10 07:11:54 +0000
@@ -161,7 +161,7 @@
     };
 
     config.save = function(result) {
-        var review_type = Y.one("[id=field.review_type]").get('value');
+        var review_type = Y.one('[id="field.review_type"]').get('value');
         request_reviewer(result, review_type);
     };
     reviewer_picker = Y.lp.app.picker.create('ValidPersonOrTeam', config);