launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/subscription-link-login-798912 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #798912 in Launchpad itself: "Anonymous users are not prompted to login if they click the subscription link in a bug page"
  https://bugs.launchpad.net/launchpad/+bug/798912

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/subscription-link-login-798912/+merge/123887

A trivial fix - there was some bogus javascript in the bug-portlet-subscription.pt TAL which killed the +subscribe link click handler. The javascript bug subscription module later wired it up, but only if someone was logged in. So removing the bad javascript restores order to the universe.
-- 
https://code.launchpad.net/~wallyworld/launchpad/subscription-link-login-798912/+merge/123887
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/subscription-link-login-798912 into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bug-portlet-subscription.pt'
--- lib/lp/bugs/templates/bug-portlet-subscription.pt	2012-06-15 16:23:50 +0000
+++ lib/lp/bugs/templates/bug-portlet-subscription.pt	2012-09-12 06:19:26 +0000
@@ -53,15 +53,6 @@
   <script type="text/javascript">
     LPJS.use('io-base', 'node',
             'lp.bugs.bugtask_index.portlets.subscription', function(Y) {
-        // Must be done inline here to ensure the load event fires.
-        // This is a work around for a YUI3 issue with event handling.
-        var subscription_link = Y.one('.menu-link-subscription');
-        var subscription_link_handler;
-        if (subscription_link) {
-            subscription_link_handler = subscription_link.on(
-                'click', function(e) { e.preventDefault(); });
-        }
-
         Y.on('domready', function() {
             Y.lp.bugs.bugtask_index.portlets.subscription.initialize();
         });