launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/maas/use-new-nodegroupinterface into lp:maas has been updated.

Description changed to:

This branch changes the code so that it uses the network-related info on nodegroupinterface rather than using the old field on nodegroup.  It also removes the old fields on nodegroup.

This will be the basis for most of the future DHCP-related work so please review this with caution.  It goes without saying that I'll be very happy to improve that code based on any meaningful suggestion.

= Pre-imp =

This was discussed with Julian.

= Notes =

- Since we only want to support one managed interface, I've introduced the method 'get_managed_interface()' on nodegroup which returns the only managed interface on a nodegroup. Enforcing that there is only one managed nodegroup at a time will be done when we will get to creating method to actually modify that information.

- The nodegroup creation method (in nodegroup.py or in the test factory) have been extended to create a managed interface as well.  We will probably want to change that when we will want to support multiple interfaces but I think this is the best way to go forward for now.

- nodegroup.is_dhcp_enabled now simply delegates that check to the managed interface (if any).

- we didn't really bother with data migration because all that DHCP-related code is still new and has not been released in a packaged version.

For more details, see:
https://code.launchpad.net/~rvb/maas/use-new-nodegroupinterface/+merge/123915
-- 
https://code.launchpad.net/~rvb/maas/use-new-nodegroupinterface/+merge/123915
Your team MAAS Maintainers is requested to review the proposed merge of lp:~rvb/maas/use-new-nodegroupinterface into lp:maas.