launchpad-reviewers team mailing list archive

Thread
Date

launchpad-reviewers team
Mailing list archive
Message #11886

Re: [Merge] lp:~abentley/launchpad/fix-banner into lp:launchpad

To: Aaron Bentley <aaron@xxxxxxxxxxxxx>
From: Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>
Date: Wed, 12 Sep 2012 20:42:17 -0000
In-reply-to: <20120912203118.14638.22771.launchpad@ackee.canonical.com>
Reply-to: mp+124052@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

As mentioned on IRC, consider making the test more specific to ensure the phrase is actually in the banner and not somewhere else in browser.contents. Otherwise, this looks great.  I particularly like the IInformationType approach to this.
-- 
https://code.launchpad.net/~abentley/launchpad/fix-banner/+merge/124052
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~abentley/launchpad/fix-banner into lp:launchpad
From: Aaron Bentley, 2012-09-12