← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~deryck/launchpad/sharing-page-for-specifications into lp:launchpad

 

Thanks for the review, Ian!

I'll definitely do #1, good suggestion.  And #2 as well.  I knew it was bad form, but trying not to go to 2 lines with our formatting guidelines. :)  And yeah, with #3 SQL might have been easier, but I followed the pattern set by others here.  I'll just stick with since the code is done, and just in case I don't understand some nuance about using the garbo job.

Thanks again!  And thanks for the notes about the reload choice. 
-- 
https://code.launchpad.net/~deryck/launchpad/sharing-page-for-specifications/+merge/124314
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References