launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/trivial into lp:launchpad.

Requested reviews:
  Stuart Bishop (stub)
Related bugs:
  Bug #951401 in Launchpad itself: "parse-ppa-apache-logs failing (missing files)"
  https://bugs.launchpad.net/launchpad/+bug/951401

For more details, see:
https://code.launchpad.net/~stub/launchpad/trivial/+merge/125149

= Summary =

Everytime staging is rebuilt, there are hundreds of lines of annoying rsync output

== Proposed fix ==

Emit rsync output at DEBUG level, so it is off by default yet can be trivially logged to a separate file if anyone actually wants it.

== Pre-implementation notes ==

== LOC Rationale ==

== Implementation details ==

== Tests ==

== Demo and Q/A ==


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  buildout-templates/scripts/mlist-sync.py.in
-- 
https://code.launchpad.net/~stub/launchpad/trivial/+merge/125149
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'buildout-templates/scripts/mlist-sync.py.in'
--- buildout-templates/scripts/mlist-sync.py.in	2012-02-03 20:07:04 +0000
+++ buildout-templates/scripts/mlist-sync.py.in	2012-09-19 10:01:26 +0000
@@ -118,7 +118,7 @@
                                    stderr=subprocess.PIPE)
         stdout, stderr = process.communicate()
         if process.returncode == 0:
-            self.logger.info('%s', stdout)
+            self.logger.debug('%s', stdout)
         else:
             self.logger.error('rsync command failed with exit status: %s',
                               process.returncode)