launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/maas/dig-even-bloody-slower into lp:maas.

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~allenap/maas/dig-even-bloody-slower/+merge/125361
-- 
https://code.launchpad.net/~allenap/maas/dig-even-bloody-slower/+merge/125361
Your team MAAS Maintainers is requested to review the proposed merge of lp:~allenap/maas/dig-even-bloody-slower into lp:maas.

=== modified file 'src/maastesting/tests/test_bindfixture.py'
--- src/maastesting/tests/test_bindfixture.py	2012-09-19 20:11:23 +0000
+++ src/maastesting/tests/test_bindfixture.py	2012-09-19 22:36:30 +0000
@@ -44,8 +44,11 @@
     :return: The output as a string.
     :rtype: basestring
     """
+    # The time and tries below are high so that tests pass in environments
+    # that are much slower than the average developer's machine, so beware
+    # before lowering. Many Bothans died to discover these parameters.
     cmd = [
-        'dig', '+time=5', '+tries=3', '@%s' % server, '-p',
+        'dig', '+time=10', '+tries=5', '@%s' % server, '-p',
         '%d' % port]
     if commands is not None:
         if not isinstance(commands, list):