launchpad-reviewers team mailing list archive

[Robie Basak <robie.basak@xxxxxxxxxxxxx>]

Robie Basak has proposed merging lp:~racb/maas/ipmipower-stdin-lp-1053391 into lp:maas.

Commit message:
Work around ipmipower requiring input on stdin
  
ipmipower doesn't work with stdin connected to /dev/null, so connect it to something else as a workaround.

Requested reviews:
  MAAS Maintainers (maas-maintainers)
Related bugs:
  Bug #1053391 in MAAS: "ipmipower fails if stdin returns EOF"
  https://bugs.launchpad.net/maas/+bug/1053391

For more details, see:
https://code.launchpad.net/~racb/maas/ipmipower-stdin-lp-1053391/+merge/125518
-- 
https://code.launchpad.net/~racb/maas/ipmipower-stdin-lp-1053391/+merge/125518
Your team MAAS Maintainers is requested to review the proposed merge of lp:~racb/maas/ipmipower-stdin-lp-1053391 into lp:maas.

=== modified file 'src/provisioningserver/power/templates/ipmi.template'
--- src/provisioningserver/power/templates/ipmi.template	2012-09-17 17:27:02 +0000
+++ src/provisioningserver/power/templates/ipmi.template	2012-09-20 15:57:23 +0000
@@ -23,6 +23,8 @@
 
 # Issue command to ipmipower, for the given system.
 issue_ipmi_command() {
+    # See https://launchpad.net/bugs/1053391 for details of this workaround
+    echo workaround |\
     ${ipmipower} -h ${power_address} -u ${power_user} -p ${power_pass} --$1
 }