launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/ajax-oops-link into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/ajax-oops-link/+merge/125609

Change the URL calculated for OOPS in the ajax log. I'd prefer if this was backed off the config set in schema-lazr.conf, but it will do for now.
-- 
https://code.launchpad.net/~stevenk/launchpad/ajax-oops-link/+merge/125609
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/ajax-oops-link into lp:launchpad.

=== modified file 'lib/lp/app/javascript/ajax_log.js'
--- lib/lp/app/javascript/ajax_log.js	2012-02-13 20:50:09 +0000
+++ lib/lp/app/javascript/ajax_log.js	2012-09-20 23:55:27 +0000
@@ -53,6 +53,7 @@
                 */
                 Y.all('#ajax-time-list li.no-events').remove();
                 if (ajax_request_times[transactionid]) {
+                    var oops_url = 'https://oops.canonical.com/oops/?oopsid=';
                     var start_time = ajax_request_times[transactionid];
                     /* The time take for the AJAX event, in seconds.
                     */
@@ -76,8 +77,7 @@
                     var oops = response.getResponseHeader('X-Lazr-OopsId');
                     if (oops) {
                         var oops_node = Y.Node.create('<a/>');
-                        oops_node.setAttribute(
-                            'href', 'http://pad.lv/' + oops);
+                        oops_node.setAttribute('href', oops_url + oops);
                         oops_node.set('text', oops);
                         log_node.one('span').append(', OOPS ID:&nbsp;');
                         log_node.one('span').append(oops_node);