launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/maas/make-run-work into lp:maas.

Commit message:
Get `make run` to start all region and cluster services.

Previously it was only starting the region's services.

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~allenap/maas/make-run-work/+merge/125741
-- 
https://code.launchpad.net/~allenap/maas/make-run-work/+merge/125741
Your team MAAS Maintainers is requested to review the proposed merge of lp:~allenap/maas/make-run-work into lp:maas.

=== modified file 'Makefile'
--- Makefile	2012-09-18 19:06:21 +0000
+++ Makefile	2012-09-21 15:01:20 +0000
@@ -193,6 +193,7 @@
 
 service_names_region := database dns reloader txlongpoll web webapp
 service_names_cluster := celeryd pserv reloader
+service_names_all := $(service_names_region) $(service_names_cluster)
 
 # The following template is intended to be used with `call`, and it
 # accepts a single argument: a target name. The target name must
@@ -221,7 +222,8 @@
 	@services/run $(service_names_region)
 run-cluster:
 	@services/run $(service_names_cluster)
-run: run-region run-cluster
+run:
+	@services/run $(service_names_all)
 
 phony_services_targets += run-region run-cluster run