launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

14	+ yield UploadError("Unable to parse file line, check section.")

That's pretty vague, misleading, and looks bad. Perhaps "Wrong number of fields in Files line in .changes."?

I'd also really prefer that we stopped creating malformed uploads for this. Unit tests are good.
-- 
https://code.launchpad.net/~stevenk/launchpad/deal-with-badly-formed-section/+merge/125908
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.