launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~rharding/launchpad/regjs into lp:launchpad

To: mp+125780@xxxxxxxxxxxxxxxxxx
From: Benji York <benji.york@xxxxxxxxxxxxx>
Date: Mon, 24 Sep 2012 14:40:26 -0000
In-reply-to: <20120924143119.30858.72195.launchpad@ackee.canonical.com>
Reply-to: mp+125780@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

This branch looks fine.  I have one concern though.

In lib/lp/registry/javascript/tests/test_product_views.html, the very
large HTML template makes me worry about maintainability.  Will that
have to be carefully hand maintained?  Was that generated by something?
If so, can we generate it at runtime instead?

-- 
https://code.launchpad.net/~rharding/launchpad/regjs/+merge/125780
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/regjs into lp:launchpad.

References

[Merge] lp:~rharding/launchpad/regjs into lp:launchpad
From: Richard Harding, 2012-09-24