launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/start-cluster-controller into lp:maas has been updated.

Description changed to:

See commit message.  Pre-imps for various aspects with Julian, Gavin, and Raphael.

The new command takes one argument: the URL for the region controller.  It calls the "register" API operation there, which is what returns RabbitMQ connection information once the requesting cluster controller has been approved.

My code tells celery which broker to contact by setting CELERY_BROKER_URL, which is new in python 2.4.  It overrides any URL that may have been set in the celeryconfig.  The URL we used to set was the default anyway; there really is no reason to mention it in the config now.

Since cluster-controller registration is an unauthenticated API call, I added an alternative to MAASOAuth called NoAuth which fills the same slot in MAASClient but does not do any authentication.  We may end up wanting to use that in more places.

In the future we'll also want to pass this a queue name, but it has no dedicated place on the cluster controller yet.  Also, for now, the master cluster uses a special value "celery" as a queue name.  We'll want to resolve that.

With this in place, we can drop our Upstart script for celery from the packaging branch.  To replace it, we'll want something that calls "maas-provision start-cluster-controller <region-controller-url>."  The parameter will come from a branch that Julian is currently working on.

Jeroen

For more details, see:
https://code.launchpad.net/~jtv/maas/start-cluster-controller/+merge/126031
-- 
https://code.launchpad.net/~jtv/maas/start-cluster-controller/+merge/126031
Your team MAAS Maintainers is requested to review the proposed merge of lp:~jtv/maas/start-cluster-controller into lp:maas.