launchpad-reviewers team mailing list archive

[Benji York <benji.york@xxxxxxxxxxxxx>]

Review: Approve code

Looks good.  A couple of minor comments:

As a reader of the code, I would appreciate a comment above line 122 of the
diff describing the significance of having a space in the context name.

Line 122-124 of the diff contains the comment

# This is a view of a generated view class,
# such as ++model++ view of Product:+bugs. Recuse!

Is "Recuse" a typo?  It seems to me that it should be "recurse".

I suppose the function is recusing itself from working further, but that's a
stretch. :)

-- 
https://code.launchpad.net/~sinzui/launchpad/pageids/+merge/126081
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.