launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/maas/default-crud into lp:maas has been updated.

Description changed to:

This branch adds the ability to define normal CRUD operations alongside "real" operations (i.e. calls with op=something).

I did that branch because I don't want us to be forced to support an API method that is a POST and does not modify data.

= Pre-imp =

No real pre-imp for this but:
- all the details (and probably more) is documented on bug 1049933.
- this was discussed with jam when he added the XXXed code that this branch cleans up.

= Notes =

It boils down to this: since we hijack the default CRUB operations in order to allow the API to route request to the right method depending on the value of the 'op' parameter, we removed the possibility to have both CRUB operations alongside real operations for the same method ('GET', 'POST', etc.) on a handler.

I choose to extend our @api_exported utility because I think that fits best with our model.  Another solution would have been to dynamically save the default method ('read', 'create', etc.) to avoid it to be overridden by our custom method (remember, we replace the default method to route requests) but I thought this would have been more clumsy.

For more details, see:
https://code.launchpad.net/~rvb/maas/default-crud/+merge/126413
-- 
https://code.launchpad.net/~rvb/maas/default-crud/+merge/126413
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/default-crud into lp:maas.