launchpad-reviewers team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

The proposal to merge lp:~smoser/maas/trunk.import-ephem-fix into lp:maas has been updated.

Commit Message changed to:

maas-import-ephemerals: cleanups and one bug fix

Bug: 
  if you were importing 2 things, the query_local would not re-set the
  'l_dir' (local dir), which caused a sour path to be taken.

cleanups:
 * remove 'arch2u' as we only deal with ubuntu arch now. x86_64 is not
   valid input that should exist anywhere.
 * be less annoying in default output. Now, nothing to do looks like:
     precise/amd64: up to date [maas-precise-daily-amd64-ephemeral-20120924]
     precise/i386: up to date [maas-precise-daily-i386-ephemeral-20120924]
     quantal/amd64: up to date [maas-quantal-daily-amd64-ephemeral-20120926]
     quantal/i386: up to date [maas-quantal-daily-i386-ephemeral-20120926]
 * replace 2 separate install_tftp_image with a single one
 * do not let output of maas-provision to stdout/stderr unless it fails

For more details, see:
https://code.launchpad.net/~smoser/maas/trunk.import-ephem-fix/+merge/126543
-- 
https://code.launchpad.net/~smoser/maas/trunk.import-ephem-fix/+merge/126543
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~smoser/maas/trunk.import-ephem-fix into lp:maas.