launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/r16039-textfix into lp:launchpad.

Commit message:
Fix bugs doc tests since retargetting bugs now returns 301 status.

Requested reviews:
  Ian Booth (wallyworld)
Related bugs:
  Bug #628352 in Launchpad itself: "Calling setOwner on a branch via web API OOPses even though operation is successful"
  https://bugs.launchpad.net/launchpad/+bug/628352

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/r16039-textfix/+merge/126588

Test fix - update xx-bug.txt doc test since retargetting a bug now gives a status of 301.
-- 
https://code.launchpad.net/~wallyworld/launchpad/r16039-textfix/+merge/126588
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/bugs/stories/webservice/xx-bug.txt'
--- lib/lp/bugs/stories/webservice/xx-bug.txt	2012-08-08 07:22:51 +0000
+++ lib/lp/bugs/stories/webservice/xx-bug.txt	2012-09-27 01:48:21 +0000
@@ -452,7 +452,9 @@
     >>> print webservice.named_post(
     ...     task['self_link'], 'transitionToTarget',
     ...     target=webservice.getAbsoluteUrl('/debian/+source/evolution'))
-    HTTP/1.1 200 Ok
+    HTTP/1.1 301 Moved Permanently
+    ...
+    Location: http://api.launchpad.dev/beta/debian/+source/evolution/+bug/1
     ...
 
 We can also PATCH the target attribute to accomplish the same thing.
@@ -483,7 +485,9 @@
     >>> print webservice.named_post(
     ...     product_bugtask['self_link'], 'transitionToTarget',
     ...     target=webservice.getAbsoluteUrl('/bzr'))
-    HTTP/1.1 200 Ok
+    HTTP/1.1 301 Moved Permanently
+    ...
+    Location: http://api.launchpad.dev/beta/bzr/+bug/14
     ...
 
 If the milestone of a task is on a target other than the new
@@ -506,7 +510,9 @@
     ...     firefox_bugtask['self_link'],
     ...     'transitionToTarget',
     ...     target=webservice.getAbsoluteUrl('/jokosher'))
-    HTTP/1.1 200 Ok
+    HTTP/1.1 301 Moved Permanently
+    ...
+    Location: http://api.launchpad.dev/beta/jokosher/+bug/1
     ...
     <BLANKLINE>
     >>> jokosher_bugtask = webservice.get(
@@ -519,7 +525,9 @@
     ...     jokosher_bugtask['self_link'],
     ...     'transitionToTarget',
     ...     target=webservice.getAbsoluteUrl('/firefox'))
-    HTTP/1.1 200 Ok
+    HTTP/1.1 301 Moved Permanently
+    ...
+    Location: http://api.launchpad.dev/beta/firefox/+bug/1
     ...
 
 We can change a distribution task to a task with a package from the same
@@ -537,7 +545,10 @@
     >>> print webservice.named_post(
     ...     distro_bugtask_path, 'transitionToTarget',
     ...     target=webservice.getAbsoluteUrl('/ubuntu/+source/alsa-utils'))
-    HTTP/1.1 200 Ok ...
+    HTTP/1.1 301 Moved Permanently
+    ...
+    Location: http://api.launchpad.dev/beta/ubuntu/+source/alsa-utils/+bug/19
+    ...
 
 It's possible to get a list of similar bugs for a bug task by calling
 its findSimilarBugs() method. As it happens, there aren't any bugs