← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~julian-edwards/maas/enlist-power-params into lp:maas

 

As discussed on IRC, this hardcodes the power_parameter specific to IPMI.  That's not right.  I suggest you create a first version that will accept a json blog name power_parameter and store it blindly, no questions asked.  Then we could iterate on that and add proper validation on top of that using the structure defined in src/maasserver/power_parameters.py.
-- 
https://code.launchpad.net/~julian-edwards/maas/enlist-power-params/+merge/126619
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/maas/enlist-power-params into lp:maas.


References