← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~abentley/launchpad/storm-sprint-queries into lp:launchpad

 

Review: Needs Information

This looks alright, but I'm not sure I see the value in the completeness expression being a class method on the Specification class--it seems like something that could just be defined as a clause separately in that code rather than a class method, and then used as needed. Is there some other reason for this implementation?

Also: I concur with the lack of a need for an explicit implementation for Priority, but that should probably be added in a comment in the relevant block of code.
-- 
https://code.launchpad.net/~abentley/launchpad/storm-sprint-queries/+merge/126770
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


Follow ups

References