launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

> As one minor point, it might be cleaner to set the default argument for user
> in `specifications` to None, rather than passing in None everytime you need
> it. But I don't see that as a blocker to approval--it's just a thought.

I don't think it would be cleaner to set a default, because it would encourage mistakes and sloppy use.  The fact is that you need to decide what user to use in all cases.  What's worse, mistakes will cause only subtle differences and may go undetected.  Deciding to use None is valid, but in most cases you'll be passing in a variable that may or may not have been set to None, like ILaunchBag.user or LaunchpadView.user.
-- 
https://code.launchpad.net/~abentley/launchpad/hide-sprint-blueprints/+merge/126792
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.