← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jameinel/maas/cpu_mem_tag_constraints into lp:maas

 

I see that the API acceptance tests cover a lot of the same behaviours as the unit tests (and then there is some redundancy between unit tests as well).  My guess is that the acceptance tests were written first, then the lower-level helpers were created to satisfy the tests, and those helpers were then unit-tested.  I do that a lot as well, but I find it's usually best to strip down the acceptance tests to exercise integration paths only.
-- 
https://code.launchpad.net/~jameinel/maas/cpu_mem_tag_constraints/+merge/126863
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jameinel/maas/cpu_mem_tag_constraints into lp:maas.


References