← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~sinzui/launchpad/bug-subselect-timeout into lp:launchpad

 

Thank you for the review William.

I simplified the rules for appending ss clauses. Milestones are always present as you suggested. The two if-statements
check if the query is constrained to product or distro related bugs. This allowed me to remove the is_person_search variable that you pointed out was also applying to project groups. I reduced the number of vertical lines. I also revised the comment about why we search for DSP's when we know the user has constrained the search to a distroseries.
-- 
https://code.launchpad.net/~sinzui/launchpad/bug-subselect-timeout/+merge/126566
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References