← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~sinzui/launchpad/bug-subselect-timeout into lp:launchpad

 

Review: Approve code

That turned out much nicer than I thought it could, thanks! One last nitpick: "if params.product is None and params.productseries is None" can probably be further restricted with "params.project is None", although it's correct either way.
-- 
https://code.launchpad.net/~sinzui/launchpad/bug-subselect-timeout/+merge/126566
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References