launchpad-reviewers team mailing list archive

[Andres Rodriguez <andreserl@xxxxxxxxxxxxx>]

Review: Needs Fixing

Hi Raphael,

It looks good overall. However, the symlinking of maas_local_settings.py should not be removed;

+++ debian/maas-region-controller.links	2012-09-28 15:48:31 +0000
@@ -1,1 +1,1 @@
-etc/maas/maas_local_settings.py usr/share/maas/maas_local_settings.py
+etc/maas/celeryconfig.py usr/share/maas/celeryconfig.py

Note that maas-common.links symlinks maas_local_celeryconfig.py *not* maas_local_settings.py

Other than that, please update accordingly *once* this changes hit maas trunk as otherwise builds will fail.

Cheers.

-- 
https://code.launchpad.net/~rvb/maas/add-maas-cluster-packaging/+merge/127002
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/add-maas-cluster-packaging into lp:~maas-maintainers/maas/packaging.