launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

> Looks good to me.
> 
> So I can see celeryconfig_common.py is the one that contains common
> configuration which is not meant to be modified by the admin right?

Right.

 > Given that is common, I'm guessing that maas_local_celeryconfig.py in region-
> controller is used to modify those default values in celeryconfig_common.py.
> If so, shouldn't cluster-controller also need the same?

Right now, maas_local_celeryconfig.py is used by both the region worker and the cluster worker (the CLUSTER_UUID setting created by the postinst script is used by the cluster worker and the BROKER_URL is used by the region worker).  It works ok that way but it would probably be more clear to have a separate file for the cluster worker.

> I don't know whether this is possible or not, but it would be great if we
> could get rid of the common stuff so that we can avoid having maas-common.
> Let's talk on monday.

I think it's possible I need to look into it.
-- 
https://code.launchpad.net/~rvb/maas/add-maas-cluster-packaging/+merge/127002
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/add-maas-cluster-packaging into lp:~maas-maintainers/maas/packaging.