launchpad-reviewers team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Review: Approve

Looks good Abel, thank you. Some minor details follow.

256	+    def check_permissions(self, expected_permissions, used_permissions,
257	+                          type_):

There is a check_permissions function in lp.blueprints.tests.test_specification, which is very similar. Maybe we could abstract them out.


420	+    def test_access_launchpad_View_proprietary_product(self):
421	+        # Only people with grants for a prviate product can access
422	+        # attributes protected by the permission launchapd.View.

Typos: private, launchpad. The same below in test_access_launchpad_AnyAllowedPerson_proprietary_product and in
test_set_launchpad_AnyAllowedPerson_proprietary_product.


439	+    def test_access_launchpad_AnyAllowedPerson_public_product(self):
440	+        # Only logged in persons hav access to properties of public products

Typo: have

475	+    def test_set_launchpad_AnyAllowedPerson_public_product(self):
476	+        # Only logged in users can set attributes protected by the
477	+        # permission launchapd.AnyAllowedPerson.

Typo: launchpad





-- 
https://code.launchpad.net/~adeuring/launchpad/product-sharing-sec-adapter/+merge/127473
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.