launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/pkg-cluster-user into lp:~maas-maintainers/maas/packaging.

Commit message:
Set an explicit user/group when running the cluster controller.

This leaves us free to change the default user/group for the start-cluster-controller later.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/pkg-cluster-user/+merge/127624

This accommodates a suggestion by Gavin: to make start-cluster-controller default to the user it's already being run under (but refuse to run it as root).  That change would make it easy to run in development environments, as your current user.  But we can't do it without specifying an explicit user/group in the upstart script first.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/pkg-cluster-user/+merge/127624
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/pkg-cluster-user into lp:~maas-maintainers/maas/packaging.

=== modified file 'debian/maas-cluster-controller.maas-cluster-celery.upstart'
--- debian/maas-cluster-controller.maas-cluster-celery.upstart	2012-10-02 18:42:28 +0000
+++ debian/maas-cluster-controller.maas-cluster-celery.upstart	2012-10-03 02:13:22 +0000
@@ -22,5 +22,5 @@
 
 script
     . $CONFIG_FILE  # sets MAAS_URL
-    exec /usr/sbin/maas-provision start-cluster-controller $MAAS_URL
+    exec /usr/sbin/maas-provision start-cluster-controller $MAAS_URL -u maas -g maas
 end script