launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/services-cluster-run-uid into lp:maas.

Commit message:
In a dev instance, run the cluster controller under the current user's identity.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/services-cluster-run-uid/+merge/127717

Raphael spotted the need for this.  The setuid/setgid will succeed (no-ops, basically) if the requested user identity is the same as the actual user identity, without any need for special privilege.

Surprisingly, the "fghack" is still needed.  Without it, the services machinery will start up an additional celeryd for the cluster every 10 seconds.

Jeroen
-- 
https://code.launchpad.net/~jtv/maas/services-cluster-run-uid/+merge/127717
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/services-cluster-run-uid into lp:maas.

=== modified file 'services/cluster-worker/run'
--- services/cluster-worker/run	2012-09-28 14:35:35 +0000
+++ services/cluster-worker/run	2012-10-03 11:21:23 +0000
@@ -17,4 +17,5 @@
 export PYTHONPATH=etc/:src/
 export CELERY_CONFIG_MODULE=democeleryconfig_cluster
 script="$(readlink -f bin/maas-provision)"
-exec fghack "${script}" start-cluster-controller http://0.0.0.0:5240/
+exec fghack "${script}" start-cluster-controller \
+    http://0.0.0.0:5240/ -u "$USER" -g "$USER"