launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/bloody-lint into lp:maas.

Commit message:
Some lint in trunk.  Unused variable.  There doesn't seem to be any need to generate it.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/bloody-lint/+merge/127726

Not self-approving this because I may be missing something obvious.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/bloody-lint/+merge/127726
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bloody-lint into lp:maas.

=== modified file 'src/maasserver/tests/test_api.py'
--- src/maasserver/tests/test_api.py	2012-10-03 09:16:12 +0000
+++ src/maasserver/tests/test_api.py	2012-10-03 11:41:01 +0000
@@ -2753,9 +2753,7 @@
             ContainsAll(KernelParameters._fields))
 
     def test_pxeconfig_returns_data_for_known_node(self):
-        params = self.get_mac_params()
-        node = MACAddress.objects.get(mac_address=params['mac']).node
-        response = self.client.get(reverse('pxeconfig'), params)
+        response = self.client.get(reverse('pxeconfig'), self.get_mac_params())
         self.assertEqual(httplib.OK, response.status_code)
 
     def test_pxeconfig_returns_no_content_for_unknown_node(self):