launchpad-reviewers team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

Scott Moser has proposed merging lp:~smoser/maas/revert-1151 into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~smoser/maas/revert-1151/+merge/127778

revert revno 1150 as it incorrectly reverted a fix in 1147
-- 
https://code.launchpad.net/~smoser/maas/revert-1151/+merge/127778
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~smoser/maas/revert-1151 into lp:maas.

=== modified file 'src/provisioningserver/start_cluster_controller.py'
--- src/provisioningserver/start_cluster_controller.py	2012-10-03 13:41:23 +0000
+++ src/provisioningserver/start_cluster_controller.py	2012-10-03 14:27:51 +0000
@@ -139,8 +139,8 @@
 
     # Change gid first, just in case changing the uid might deprive
     # us of the privileges required to setgid.
+    os.setgid(gid)
     os.setuid(uid)
-    os.setgid(gid)
 
     os.execvpe(command[0], command, env=env)