launchpad-reviewers team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

Review: Needs Fixing

48	+ fargs="--power-type=ipmi --power-parameters=$power_settings"
49	+ signal $fargs WORKING "finished [maas-ipmi-autodetect]"

That is wrong.
shell will incorrectly expand that to not do what you want on line 49 (plus, its up for shell expansion).

Correct way is:

signal "--power-type=ipmi" "--power-parameters=${power_settings}" WORKING "finished [maas-ipmi-autodetect]"


Other thing is less severe, but more stlylish.
put the actual stuff you're doing in the 'main' routine.

rather than outside (aptget, loadmodules)...
-- 
https://code.launchpad.net/~andreserl/maas/maas_ipmi_autodetection/+merge/127911
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~andreserl/maas/maas_ipmi_autodetection into lp:maas.