launchpad-reviewers team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

I'm not saying there should not be functions. but that they should be called from main. 

On Oct 3, 2012, at 8:44 PM, Julian Edwards <julian.edwards@xxxxxxxxxxxxx> wrote:

>> Other thing is less severe, but more stlylish.
>> put the actual stuff you're doing in the 'main' routine.
>> 
>> rather than outside (aptget, loadmodules)...
> 
> Andres is doing it correctly IMO.  Refactoring into small, well-defined functions makes debugging easier, testing easier and writing easier.
> 
> Alas, there are no tests.  How can I convince you guys to write tests?
> -- 
> https://code.launchpad.net/~andreserl/maas/maas_ipmi_autodetection/+merge/127911
> You are reviewing the proposed merge of lp:~andreserl/maas/maas_ipmi_autodetection into lp:maas.
> 

-- 
https://code.launchpad.net/~andreserl/maas/maas_ipmi_autodetection/+merge/127911
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~andreserl/maas/maas_ipmi_autodetection into lp:maas.