launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Badin has proposed merging lp:~rvb/maas/add-interface-message into lp:maas.

Commit message:
This branch adds a simple message to the interface edition page to remind the user to install maas-dhcp or maas-dns when enabling DHCP or DNS management.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~rvb/maas/add-interface-message/+merge/128012

This branch adds a simple message to the interface edition page to remind the user to install maas-dhcp or maas-dns when enabling DHCP or DNS management.

= Pre-imp =

This was discussed with Julian.

= Notes =

Screenshot:
http://people.canonical.com/~rvb/interface_message.png

A better solution would have been to add a proper validator attached to the 'management' field: this validator would have to check the presence of the maas-dns package when enabling DNS management and would (somehow) have to check the presence of the maas-dhcp package on the cluster when enabling DHCP management.
Since we don't really have time for this right now, this is better than nothing.
-- 
https://code.launchpad.net/~rvb/maas/add-interface-message/+merge/128012
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/add-interface-message into lp:maas.

=== modified file 'src/maasserver/forms.py'
--- src/maasserver/forms.py	2012-10-03 11:19:13 +0000
+++ src/maasserver/forms.py	2012-10-04 13:06:32 +0000
@@ -648,7 +648,13 @@
 
     management = forms.TypedChoiceField(
         choices=NODEGROUPINTERFACE_MANAGEMENT_CHOICES, required=False,
-        coerce=int, empty_value=NODEGROUPINTERFACE_MANAGEMENT.DEFAULT)
+        coerce=int, empty_value=NODEGROUPINTERFACE_MANAGEMENT.DEFAULT,
+        help_text=(
+            "If you enable DHCP management, you will need to install the "
+            "'maas-dhcp' package on this cluster controller.  Similarly, you "
+            "will need to install the 'maas-dns' package on this region "
+            "controller to be able to enable DNS management."
+            ))
 
     class Meta:
         model = NodeGroupInterface