launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/r16093-testfix into lp:launchpad.

Commit message:
Fix broken xx-bug-release-management.txt tests.

Requested reviews:
  Ian Booth (wallyworld)

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/r16093-testfix/+merge/128142

Fix broken xx-bug-release-management.txt tests.
-- 
https://code.launchpad.net/~wallyworld/launchpad/r16093-testfix/+merge/128142
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/bugs/stories/bug-release-management/xx-bug-release-management.txt'
--- lib/lp/bugs/stories/bug-release-management/xx-bug-release-management.txt	2012-10-02 06:36:44 +0000
+++ lib/lp/bugs/stories/bug-release-management/xx-bug-release-management.txt	2012-10-04 23:53:23 +0000
@@ -1,17 +1,11 @@
 Privileged users can approve and decline bug nominations from the bug
 page.
 
-The approve/decline links and buttons aren't visible to unprivileged users.
+The approve/decline buttons and buttons aren't visible to unprivileged users.
 
     >>> no_priv_browser = setupBrowser(
     ...     auth="Basic no-priv@xxxxxxxxxxxxx:test")
     >>> no_priv_browser.open("http://launchpad.dev/bugs/1";)
-    >>> no_priv_browser.getLink(
-    ...     url="http://launchpad.dev/firefox/+bug/1/nominations/";
-    ...         "1/+editstatus")
-    Traceback (most recent call last):
-      ...
-    LinkNotFoundError
 
     >>> no_priv_browser.getControl("Approve")
     Traceback (most recent call last):
@@ -26,12 +20,6 @@
 But an admin can see them.
 
     >>> admin_browser.open("http://bugs.launchpad.dev/bugs/1";)
-    >>> approve_decline_link = admin_browser.getLink(
-    ...     url="http://bugs.launchpad.dev/firefox/+bug/1/nominations/";
-    ...         "1/+editstatus")
-    >>> print approve_decline_link.text
-    approve/decline
-
     >>> approve_button = admin_browser.getControl("Approve", index=0)
     >>> decline_button = admin_browser.getControl("Decline", index=0)
 
@@ -61,12 +49,6 @@
 Privileged users can decline bug nominations.
 
     >>> admin_browser.open("http://bugs.launchpad.dev/bugs/1";)
-    >>> approve_decline_link = admin_browser.getLink(
-    ...     url="http://bugs.launchpad.dev/firefox/+bug/1/nominations/";
-    ...         "2/+editstatus")
-    >>> print approve_decline_link.text
-    approve/decline
-
     >>> approve_button = admin_browser.getControl("Approve", index=0)
     >>> decline_button = admin_browser.getControl("Decline", index=0)