launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/obliterate-milestone_assignment into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #808950 in Launchpad itself: "AssertionError: You exported name as an IChoice based on an SQLObjectVocabularyBase, you should use lazr.restful.fields.ReferenceChoice instead"
  https://bugs.launchpad.net/launchpad/+bug/808950

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/obliterate-milestone_assignment/+merge/128158

No longer export milestone_assignment for IBugTarget.searchTasks(). This intentionally breaks the 1.0 API, but anyone using it will only gets OOPSes and not results. It is also not tested, the only test that mentions it has been disabled since 2005.

Based on the digging that William did, this was used for the bulk edit of bugtasks which used the same schema as searchTasks -- which was removed in 2006.

So, death to milestone_assignment and good riddance.
-- 
https://code.launchpad.net/~stevenk/launchpad/obliterate-milestone_assignment/+merge/128158
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/obliterate-milestone_assignment into lp:launchpad.

=== modified file 'lib/lp/bugs/interfaces/bugtarget.py'
--- lib/lp/bugs/interfaces/bugtarget.py	2012-09-21 00:28:49 +0000
+++ lib/lp/bugs/interfaces/bugtarget.py	2012-10-05 04:02:20 +0000
@@ -1,13 +1,10 @@
 # Copyright 2010-2012 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
-# pylint: disable-msg=E0211,E0213
-
 """Interfaces related to bugs."""
 
 __metaclass__ = type
 
-
 __all__ = [
     'BugDistroSeriesTargetDetails',
     'IBugTarget',
@@ -93,8 +90,6 @@
     "tags_combinator": copy_field(IBugTaskSearch['tags_combinator']),
     "omit_duplicates": copy_field(IBugTaskSearch['omit_dupes']),
     "status_upstream": copy_field(IBugTaskSearch['status_upstream']),
-    "milestone_assignment": copy_field(
-        IBugTaskSearch['milestone_assignment']),
     "milestone": copy_field(IBugTaskSearch['milestone']),
     "component": copy_field(IBugTaskSearch['component']),
     "nominated_for": Reference(schema=Interface),
@@ -251,11 +246,11 @@
                     distribution=None, tags=None,
                     tags_combinator=BugTagsSearchCombinator.ALL,
                     omit_duplicates=True, omit_targeted=None,
-                    status_upstream=None, milestone_assignment=None,
-                    milestone=None, component=None, nominated_for=None,
-                    sourcepackagename=None, has_no_package=None,
-                    hardware_bus=None, hardware_vendor_id=None,
-                    hardware_product_id=None, hardware_driver_name=None,
+                    status_upstream=None, milestone=None, component=None,
+                    nominated_for=None, sourcepackagename=None,
+                    has_no_package=None, hardware_bus=None,
+                    hardware_vendor_id=None, hardware_product_id=None,
+                    hardware_driver_name=None,
                     hardware_driver_package_name=None,
                     hardware_owner_is_bug_reporter=None,
                     hardware_owner_is_affected_by_bug=False,

=== modified file 'lib/lp/bugs/interfaces/bugtasksearch.py'
--- lib/lp/bugs/interfaces/bugtasksearch.py	2012-09-24 05:17:00 +0000
+++ lib/lp/bugs/interfaces/bugtasksearch.py	2012-10-05 04:02:20 +0000
@@ -370,11 +370,11 @@
                        distribution=None, tags=None,
                        tags_combinator=BugTagsSearchCombinator.ALL,
                        omit_duplicates=True, omit_targeted=None,
-                       status_upstream=None, milestone_assignment=None,
-                       milestone=None, component=None, nominated_for=None,
-                       sourcepackagename=None, has_no_package=None,
-                       hardware_bus=None, hardware_vendor_id=None,
-                       hardware_product_id=None, hardware_driver_name=None,
+                       status_upstream=None, milestone=None, component=None,
+                       nominated_for=None, sourcepackagename=None,
+                       has_no_package=None, hardware_bus=None,
+                       hardware_vendor_id=None, hardware_product_id=None,
+                       hardware_driver_name=None,
                        hardware_driver_package_name=None,
                        hardware_owner_is_bug_reporter=None,
                        hardware_owner_is_affected_by_bug=False,
@@ -547,8 +547,6 @@
     has_no_package = Bool(
         title=_('Exclude bugs with packages specified'),
         required=False, default=False)
-    milestone_assignment = Choice(
-        title=_('Target'), vocabulary="Milestone", required=False)
     milestone = List(
         title=_('Milestone'),
         description=_('Show only bug tasks targeted to this milestone.'),

=== modified file 'lib/lp/bugs/model/bugtarget.py'
--- lib/lp/bugs/model/bugtarget.py	2012-10-03 07:25:02 +0000
+++ lib/lp/bugs/model/bugtarget.py	2012-10-05 04:02:20 +0000
@@ -1,8 +1,6 @@
 # Copyright 2010-2012 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
-# pylint: disable-msg=E0611,W0212
-
 """Components related to IBugTarget."""
 
 __metaclass__ = type
@@ -54,11 +52,11 @@
                     has_patch=None, has_cve=None, distribution=None,
                     tags=None, tags_combinator=BugTagsSearchCombinator.ALL,
                     omit_duplicates=True, omit_targeted=None,
-                    status_upstream=None, milestone_assignment=None,
-                    milestone=None, component=None, nominated_for=None,
-                    sourcepackagename=None, has_no_package=None,
-                    hardware_bus=None, hardware_vendor_id=None,
-                    hardware_product_id=None, hardware_driver_name=None,
+                    status_upstream=None, milestone=None, component=None,
+                    nominated_for=None, sourcepackagename=None,
+                    has_no_package=None, hardware_bus=None,
+                    hardware_vendor_id=None, hardware_product_id=None,
+                    hardware_driver_name=None,
                     hardware_driver_package_name=None,
                     hardware_owner_is_bug_reporter=None,
                     hardware_owner_is_affected_by_bug=False,

=== modified file 'lib/lp/bugs/stories/bugattachments/xx-bugattachments.txt'
--- lib/lp/bugs/stories/bugattachments/xx-bugattachments.txt	2011-12-03 15:30:19 +0000
+++ lib/lp/bugs/stories/bugattachments/xx-bugattachments.txt	2012-10-05 04:02:20 +0000
@@ -412,23 +412,3 @@
     ...of
     ...2 results...
     ...4...
-
-Let's search for patches and unspecified attachments for firefox bugs.
-
-
-# XXX Bjorn Tillenius 2005-08-01: 
-# This test is disabled in wait for SQLObject being fixed to accept
-# both distinct=True and an orderBy argument.
-
-  XXX print http(r"""
-  ... GET /bugs/firefox?field.searchtext=&advanced=%5Bu%27Advanced%27%2C+u%27%27%5D&field.milestone_assignment=&field.milestone_assignment-empty-marker=1&field.status%3Alist=New&field.status%3Alist=Confirmed&field.status-empty-marker=1&field.importance-empty-marker=1&field.has_patch=on&field.attachmenttype-empty-marker=1&field.assignee=&field.unassigned.used=&field.milestone-empty-marker=1&search=Search HTTP/1.1
-  ... """)
-  HTTP/1.1 200 Ok
-  ...
-  ...<a...>...4...</a>...
-  ...
-  ...<a...>...1...</a>...
-  ...
-  ...2 results...
-  ...
-