← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wallyworld/launchpad/review-licence-timeout-1034908 into lp:launchpad

To: Ian Booth <ian.booth@xxxxxxxxxxxxx>
From: Abel Deuring <abel.deuring@xxxxxxxxxxxxx>
Date: Fri, 05 Oct 2012 10:43:24 -0000
In-reply-to: <20121005033027.17769.57658.launchpad@ackee.canonical.com>
Reply-to: mp+128153@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

Looks good. Just one nitpick: The new functions getPrecachedProducts(), getMilestonesAndReleases() and getDistroSourcePackages() should not have camelCased names, but get_precached_products() and so on.
-- 
https://code.launchpad.net/~wallyworld/launchpad/review-licence-timeout-1034908/+merge/128153
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wallyworld/launchpad/review-licence-timeout-1034908 into lp:launchpad
From: Ian Booth, 2012-10-05