launchpad-reviewers team mailing list archive

[Martin Packman <martin.packman@xxxxxxxxxxxxx>]

Martin Packman has proposed merging lp:~gz/maas/trivial_ui_tags_comma into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~gz/maas/trivial_ui_tags_comma/+merge/128299

On the node view page, the list of tags currently has a space before and after the separating comma. Unfortunately the django templating language is dumb, as it doesn't like its own directives being wrapped to multiple lines. So, it's a choice between extra whitespace in the html (which could be placed in non-significant places), or some rather long lines in the template. This branch goes for the long line option. 
-- 
https://code.launchpad.net/~gz/maas/trivial_ui_tags_comma/+merge/128299
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/maas/trivial_ui_tags_comma into lp:maas.

=== modified file 'src/maasserver/templates/maasserver/node_view.html'
--- src/maasserver/templates/maasserver/node_view.html	2012-10-03 03:59:53 +0000
+++ src/maasserver/templates/maasserver/node_view.html	2012-10-05 17:46:32 +0000
@@ -78,8 +78,7 @@
       <h4>Tags</h4>
       <span id="node_tags">
           {% for tag in node.tags.all %}
-            <a href="{% url 'tag-view' tag.name %}">{{ tag }}</a>
-            {% if not forloop.last %}, {% endif %}
+            <a href="{% url 'tag-view' tag.name %}">{{ tag }}</a>{% if not forloop.last %}, {% endif %}
           {% endfor %}
           {% if not node.tags.all %}
             None