launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

The clause first created by Elliot makes no sense once you remove the check for .private_bugs. It wants to subscribe someone because sharing is not on, the next line asks
    and params.target.bug_sharing_policy is None'

We know this line must evaluate to false for this branch to land, so the entire block can go. There may be other tests that can also go.
-- 
https://code.launchpad.net/~stevenk/launchpad/death-to-private_bugs/+merge/128398
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/death-to-private_bugs into lp:launchpad.