← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/die-hg-die into lp:launchpad

 

Review: Approve code

line 277 looks odd because we are passing hg info to a git arg. I think we should at least end the URL in .git

I think this is fine to land, but I wonder if we need a a script or SQL to ensure we do not have any Hg jobs queued/inprogress when we remove the code imports. Maybe we want to suspend all Hg import now (via sql or API) we can let the the existing jobs finish while this branch goes to qa. We can then check for any new Hg imports/job before we rollout.
-- 
https://code.launchpad.net/~wallyworld/launchpad/die-hg-die/+merge/128408
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References