launchpad-reviewers team mailing list archive

["Francis J. Lacoste" <francis.lacoste@xxxxxxxxxx>]

On 12-10-08 10:05 AM, Martin Packman wrote:
> I'll put up a followup branch that changes the syntax used to match
> (or approximately match) juju constraints. It will need to be a be
> stricter up front about what is accepted, so that the copy/paste idea
> actually works, as juju does some validation before passing through.

I agree with John's summary of the syntax we should support.

But just to be clear: the absolute minimum requirements is that if I
paste a juju constraints in MAAS, it should get interpreted correctly
and should show all nodes matching that constraint (but we also show
unavailable nodes - e.g. allocated, commissioning).

Now, the reverse doesn't need to be true. You should be able to enter an
alternative (better) syntax and it should work. But you wouldn't expect
to copy/paste it into Juju.

A suggestion I made to mitigate the problems related to the assymetry,
would be to show the query on the results page in a juju-normalised way
that could be pasted back into juju.

For example, you search for has_gpu arch:i386, on the results page you see:

Juju constaints searched: --maas-tags=has_gpu --arch=i386

But we can add this round-tripping support later on.


-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx


https://code.launchpad.net/~gz/maas/node_search_view/+merge/128296
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/maas/node_search_view into lp:maas.