launchpad-reviewers team mailing list archive

[Martin Packman <martin.packman@xxxxxxxxxxxxx>]

Martin Packman has proposed merging lp:~gz/maas/deflate_favicon into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~gz/maas/deflate_favicon/+merge/128737

Shrink the favicon added as part of bug 1058741 to a more reasonable 15kb from over 350kb. As could be seen my looking at a mime dump of the page, this took up a reasonable chunk of the total page transfer with uncompressed bitmaps.

As it's a bit hard to see what changed without binary diff, the steps were basically:

$ cd src/maasserver/static/img
$ icotool -x favicon.ico
$ optipng -o7 favicon*.png
# Recreate .ico with all but smallest image in raw png form
$ icotool -c favicon_1_16x16x32.png --raw=favicon_2_32x32x32 ... -o favicon.ico


-- 
https://code.launchpad.net/~gz/maas/deflate_favicon/+merge/128737
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/maas/deflate_favicon into lp:maas.

=== modified file 'src/maasserver/static/img/favicon.ico'
Binary files src/maasserver/static/img/favicon.ico	2012-10-06 13:54:05 +0000 and src/maasserver/static/img/favicon.ico	2012-10-09 15:20:29 +0000 differ